Re: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular

[Kukjin Kim]

On 01/23/14 22:16, Charles Keepax wrote:
> On Tue, Jan 21, 2014 at 04:22:22PM -0500, Paul Gortmaker wrote:
> > Despite the name mach-crag6410-module.c, the code is built for
> > MACH_WLF_CRAGG_6410 -- which is bool, and hence this code is
> > either present or absent.  It will never be modular, so using
> > module_init as an alias for __initcall can be somewhat
> > misleading.
> >
> > Fix this up now, so that we can relocate module_init from
> > init.h into module.h in the future.  If we don't do this, we'd
> > have to add module.h to obviously non-modular code, and that
> > would be a worse thing.
> >
> > Note that direct use of __initcall is discouraged, vs. one
> > of the priority categorized subgroups.  As __initcall gets
> > mapped onto device_initcall, our use of device_initcall
> > directly in this change means that the runtime impact is
> > zero -- it will remain at level 6 in initcall ordering.
> >
> > Cc: Ben Dooks<ben-linux@xxxxxxxxx>
> > Cc: Kukjin Kim<kgene.kim@xxxxxxxxxxx>
> > Cc: Russell King<linux@xxxxxxxxxxxxxxxx>
> > Cc: patches@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Paul Gortmaker<paul.gortmaker@xxxxxxxxxxxxx>
> > ---
>
> Tested-by: Charles Keepax<ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Thanks, applied.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/