Re: [PATCH v6] mfd: MAX6650/6651 support

From: Laszlo Papp
Date: Thu Feb 13 2014 - 05:34:40 EST


On Thu, Feb 13, 2014 at 9:14 AM, Laszlo Papp <lpapp@xxxxxxx> wrote:
> On Thu, Feb 13, 2014 at 8:23 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> Laszlo,
>>
>>> > +const struct regmap_config max665x_regmap_config = {
>>> > + .reg_bits = 5,
>>> > +};
>>>
>>> This would normally be static too, and I'd *really* expect to see a
>>> val_bits set here. I'm a bit surprised this works without one.
>>
>> Mark (privately) mentioned to me that this patch can't possibly work
>> given the current Regmap configuration.
>
> Strange because I have tested the change, although not for days and
> weeks. What exactly cannot possible work?

Hmm, yes, as it seems, I have not actually tested the patch set
_after_ all the modifications. I deemed some of them trivial enough,
but apparently I was wrong. In this case, sending trivial updates will
slow down, but I guess that is the way to follow. Well, I apologize.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/