RE: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

From: KY Srinivasan
Date: Wed Feb 12 2014 - 11:48:53 EST




> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, February 12, 2014 8:42 AM
> To: KY Srinivasan
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx
> Subject: Re: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the
> Freeze operation
>
> On Wed, Feb 12, 2014 at 08:40:22AM -0800, K. Y. Srinivasan wrote:
> > If the guest has a FAT file system mounted, skip it during the FREEZE
> > operation. With this change we can support host initiated backup of
> > the guest even when the guest may have FAT file systems mounted.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > ---
> > tools/hv/hv_vss_daemon.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
> > index 520de3304..6a213b8 100644
> > --- a/tools/hv/hv_vss_daemon.c
> > +++ b/tools/hv/hv_vss_daemon.c
> > @@ -87,6 +87,8 @@ static int vss_operate(int operation)
> > continue;
> > if (strcmp(ent->mnt_type, "iso9660") == 0)
> > continue;
> > + if (strcmp(ent->mnt_type, "vfat") == 0)
> > + continue;
>
> Why should the filesystem type matter here at all?

As part of snapshotting the guest, we want to freeze all mounted file systems in the guest.
FAT file system does not support the freeze operation and so we want to skip these mount
points. For VMs on UEFI firmware, the EFI partition is a FAT partition.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/