Re: [PATCH 2/5] cpuidle/idle: Move the cpuidle_idle_call function to idle.c

From: Preeti U Murthy
Date: Wed Feb 12 2014 - 05:47:39 EST


Hi Daniel,

On 02/11/2014 08:41 PM, Daniel Lezcano wrote:
> The cpuidle_idle_call does nothing more than calling the three individuals
> function and is no longer used by any arch specific code but only in the
> cpuidle framework code.
>
> We can move this function into the idle task code to ensure better
> proximity to the scheduler code.

So my understanding of this patchset is that by moving
cpuidle_idle_call() under kernel/sched, we now have a way of calling
into the cpuidle governor and the cpuidle driver with additional
parameters like cpu_load(), idle_stamp etc.. so that we can expect the
governor and driver to take better decisions about entry and exit into
idle states. Is this the advantage we hope to begin with?

Thanks

Regards
Preeti U Murthy
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Acked-by: Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>
> ---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/