[PATCH 1 of 1]: musb: fixed a potential NULL pointer dereference.

From: Dr. H. Nikolaus Schaller
Date: Wed Feb 12 2014 - 05:08:45 EST


fixed a potential NULL pointer dereference.

Rationale:
this is the only location in the musb driver where the
otg->gadget pointer is dereferenced. Assuming that it
is never NULL is not only potentially unsafe but was
observed in the wild on a GTA04 (OMAP3/TPS65950 based
board) when trying to boot a device tree based 3.14-rc2
kernel with USB cable plugged in.

DT boot appears to modify the order in which components
(gadget driver) are loaded and linked and therefore
an early musb interrupt triggers with a NULL gadget
pointer ending in a kernel panic.

Since a non-existing gadget can never be "active" we
simply use a 0 value for musb->is_active.

Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>


Attachment: 0001-fixed-a-potential-NULL-pointer-dereference.patch
Description: Binary data