Re: [PATCH v6] mfd: MAX6650/6651 support

From: Laszlo Papp
Date: Wed Feb 12 2014 - 04:34:42 EST


On Wed, Feb 12, 2014 at 8:32 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> >> + max665x->map = devm_regmap_init_i2c(i2c, &max665x_regmap_config);
>> >
>> > Don't you need to check the return value of devm_regmap_init_i2c?
>>
>> I personally think I should. I strived for consistency though with
>> other similar drivers. After this many reviews about such things, it
>> seems that consistency matters here less than other projects which I
>> can cope with, thanks.
>
> The right thing to do is normally preferred.

Yes, sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/