Re: [PATCH 0/3] of: functions to count number of elements and convert regulators

From: Mark Rutland
Date: Wed Feb 12 2014 - 04:25:50 EST


Hi Heiko,

On Tue, Feb 11, 2014 at 11:59:25PM +0000, Heiko StÃbner wrote:
> In a different thread [0] Mark Rutland suggested that drivers should not
> repeatedly open-code the counting of array elements in a property as well
> as handling the format and endianes of the DTB, as these should be limited
> to the of_ helper functions.
>
> Therefore the first patch introduces a set of helper functions for counting
> the number of u8,...,u64 elements in a property.
>
> The second and third patch convert the two regulator drivers that use this
> pattern to instead use both of_property_count_u32_elemens as well as
> of_property_read_u32_index.
>
> gpio-regulator change tested on a s3c2416-based device, ti-abb-regulator
> compile-tested only.

Cheers for this. All the patches look fine to me, so for the series:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/