Re: [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c

From: Jan Kara
Date: Tue Feb 11 2014 - 15:48:59 EST


On Sun 09-02-14 18:34:10, Rashika Kheria wrote:
> Mark function as static in ext2/xattr_security.c because it is not
> used outside this file.
>
> This also elimiantes the following warning in ext2/xattr_security.c:
> fs/ext2/xattr_security.c:45:5: warning: no previous prototype for âext2_initxattrsâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
Thanks. I've merged the patch.

Honza
> ---
> fs/ext2/xattr_security.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index cfedb2c..c0ebc4d 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
> value, size, flags);
> }
>
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> int err = 0;
> --
> 1.7.9.5
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/