Re: [PATCH v2] mfd: MAX6650/6651 support

[Laszlo Papp]

>>> [snip]
>>>> +
>>>> +struct max665x_dev {
>>>> +       struct device *dev;
>>>> +       struct mutex iolock;
>>>> +
>>>> +       struct i2c_client *i2c;
>>>> +       struct regmap     *map;
>>>> +
>>>> +       int type;
>>>
>>> Unnecessary extra lines above could be removed.
>>
>> I prefer it that way, but I will remove the two extra lines as you wish.
>
> As I already said, these are just nits and only since you were
> re-spinning the patch,
> I suggested them. Also, since this is a new file being added, it
> avoids further patches
> doing these same things.

Well, it is worse in my opinion because it makes the code more bloated
without separation between units, but I made the requested change
anyway because the feature matters lotta more to me than this styling.
Hope it is OK now?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/