Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning

From: Lee Jones
Date: Tue Feb 11 2014 - 05:04:45 EST


> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Static analysis from cppcheck issued the following warning:
>
> [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
> inside sizeof().
>
> The current size calculation is not obvious and is easy to
> miscomprehend, so re-work the size of the allocation based
> on the size of the struct pointer and quantity to allocate.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to my -fixes branch with Roger's Ack.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/