Re: [PATCH v2] powerpc ticket locks

From: Al Viro
Date: Mon Feb 10 2014 - 21:57:31 EST


On Tue, Feb 11, 2014 at 01:44:20PM +1100, Benjamin Herrenschmidt wrote:
> That leaves us with 32 bits to put the ref and the owner. The question
> is how big the ref really has to be and can we have a reasonable failure
> mode if it overflows ?
>
> If we limit ourselves to, for example, 16-bit for the ref in lockref,
> then we can have the second 32-bit split between the owner and the ref.
>
> If we limit ourselves to 4k CPUs, then we get 4 more bits of ref ...
>
> So the question is, is it reasonable to have the ref smaller than
> 32-bit...

Every time you open a file, you bump dentry refcount. Something like
libc or ld.so will be opened on just about every execve(), so I'd say
that 16 bits is far too low. If nothing else, 32 bits might be too
low on 64bit boxen...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/