Re: [PATCH 02/11] block: Remove useless IPI struct initialization

[Jan Kara]

On Sat 08-02-14 17:18:31, Frederic Weisbecker wrote:
> rq_fifo_clear() reset the csd.list through INIT_LIST_HEAD for no clear
> purpose. The csd.list doesn't need to be initialized as a list head
> because it's only ever used as a list node.
> 
> Lets remove this useless initialization.
> 
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
  Looks good. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
> ---
>  include/linux/elevator.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/linux/elevator.h b/include/linux/elevator.h
> index 0bdfd46..df63bd3 100644
> --- a/include/linux/elevator.h
> +++ b/include/linux/elevator.h
> @@ -203,10 +203,7 @@ enum {
>  #define rb_entry_rq(node)	rb_entry((node), struct request, rb_node)
>  
>  #define rq_entry_fifo(ptr)	list_entry((ptr), struct request, queuelist)
> -#define rq_fifo_clear(rq)	do {		\
> -	list_del_init(&(rq)->queuelist);	\
> -	INIT_LIST_HEAD(&(rq)->csd.list);	\
> -	} while (0)
> +#define rq_fifo_clear(rq)	list_del_init(&(rq)->queuelist)
>  
>  #else /* CONFIG_BLOCK */
>  
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/