Re: [PATCH 24/51] x86, hpet: Fix CPU hotplug callback registration

[Gautham R Shenoy]

Hi,

On Thu, Feb 06, 2014 at 03:39:00AM +0530, Srivatsa S. Bhat wrote:
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index da85a8e..199aaae 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -943,12 +943,14 @@ static __init int hpet_late_init(void)
>  	if (boot_cpu_has(X86_FEATURE_ARAT))
>  		return 0;
> 
> +	cpu_maps_update_begin();
>  	for_each_online_cpu(cpu) {
>  		hpet_cpuhp_notify(NULL, CPU_ONLINE, (void *)(long)cpu);
>  	}
> 
>  	/* This notifier should be called after workqueue is ready */
> -	hotcpu_notifier(hpet_cpuhp_notify, -20);
> +	__hotcpu_notifier(hpet_cpuhp_notify, -20);

We could #define HPET_CPUHP_PRIO relative to the workqueue priority instead of
hardcoding this it this way.


--
Thanks and Regards
gautham.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/