Re: [PATCH v2] nohz: ensure users are aware boot CPU is notNO_HZ_FULL

From: Frederic Weisbecker
Date: Mon Feb 10 2014 - 11:19:50 EST


On Thu, Feb 06, 2014 at 01:36:21PM -0500, Paul Gortmaker wrote:
> This bit of information is in the Kconfig help text:
>
> Note the boot CPU will still be kept outside the range to
> handle the timekeeping duty.
>
> However neither the variable NO_HZ_FULL_ALL, or the prompt
> convey this important detail, so lets add it to the prompt
> to make it more explicitly obvious to the average user.
>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>

Paul, I guess I can keep your ack on this 2nd version?

> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Applied, thanks a lot!

> ---
>
> v2: use "CPU 0" instead of "boot CPU".
>
> kernel/time/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index 3ce6e8c5f3fc..f448513a45ed 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -124,7 +124,7 @@ config NO_HZ_FULL
> endchoice
>
> config NO_HZ_FULL_ALL
> - bool "Full dynticks system on all CPUs by default"
> + bool "Full dynticks system on all CPUs by default (except CPU 0)"
> depends on NO_HZ_FULL
> help
> If the user doesn't pass the nohz_full boot option to
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/