Re: [PATCH 1/2] regulator: anatop: Add power gating support todigital LDOs

From: Mark Brown
Date: Mon Feb 10 2014 - 08:33:10 EST


On Mon, Feb 10, 2014 at 02:27:55PM +0100, Philipp Zabel wrote:

> yes, thanks. I'll fix this. What should happen if the
> regulator_set_voltage_sel_regmap fails? Is it ok to still
> set the cache in this case?

Either way is fine but not updating the cache is probably better - if it
was a physical write we'd not actually be sure if the write made it to
hardware (it could also have written nonsense!) so we can't really
guarantee what the state is after a failed operation.

Attachment: signature.asc
Description: Digital signature