Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

From: Ulf Hansson
Date: Mon Feb 10 2014 - 05:17:02 EST


On 5 February 2014 15:45, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
>> +static int nmk_i2c_runtime_resume(struct device *dev)
>> +{
>> + struct amba_device *adev = to_amba_device(dev);,
>> + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev);
>> +
>> + clk_prepare_enable(nmk_i2c->clk);
>
> Previously the code was checking the return value from
> clk_prepare_enable(). You should keep the check here.

Will fix in v2! Thanks for reviewing!

Kind regards
Ulf Hansson

>
> Regards,
>
> Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/