Re: [PATCH] spi: omap2: use SUPERH, not SH

From: Geert Uytterhoeven
Date: Sat Feb 08 2014 - 16:19:29 EST


On Sat, Feb 8, 2014 at 10:01 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> Commit 0079aae0f1e6 ("spi: omap2: Add build dependencies for
> writel_relaxed()") added an optional Kconfig dependency on SH. That
> Kconfig symbol doesn't exist. Apparently SUPERH was intended. Use that.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>

Nice catch!

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

BTW, MICROBLAZE can be added as well. It got writel_relaxed() in
v3.14-rc1.

> ---
> Basically untested.
>
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index ba9310b..205dbfe 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -307,7 +307,7 @@ config SPI_OMAP_UWIRE
>
> config SPI_OMAP24XX
> tristate "McSPI driver for OMAP"
> - depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SH
> + depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SUPERH
> depends on ARCH_OMAP2PLUS || COMPILE_TEST
> help
> SPI master controller for OMAP24XX and later Multichannel SPI

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/