Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

From: Pali RohÃr
Date: Wed Feb 05 2014 - 11:39:43 EST

2014-02-05 Sebastian Reichel <sre@xxxxxxxxxx>:
> Hi Pali,
> On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali RohÃr wrote:
>> 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead #ifdef ?
> This is the preferred kernel style as far as I know.


>> 2) Why do you not write warning or info when omap type is not
>> OMAP2_DEVICE_TYPE_SEC (e.g qemu) ?
> I assumed, that the workaround is not needed for this device type.

That rx51 secure call must not be called on non secure devices (e.g.
qemu), because it cause kernel crash. So I thought that kernel should
write something like secure call is disabled on that device types.
Kernel code for errata 430973 will update ibe bit for non secure

> I just added the warning for missing CONFIG_ARM_ERRATA_430973,
> because its very likely a misconfigured kernel.
> -- Sebastian

Yes, it can be misconfigured kernel, but if you do not have any thumb
binary (like stock Maemo 5 system), then it is safe and OK.

Pali RohÃr
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at