Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

From: David Lanzendörfer
Date: Wed Feb 05 2014 - 08:02:34 EST

Hi Maxime
> I have four comments here:
> - Read Documentation/SubmittingPatches, especially Section 5 and 12
> (hints, you forgot the clock maintainers for your clock patches
> and you didn't put any signed-off-by tags)
Oops. I added signed-offs now
> - You ignored pretty much all the comments that were made during the
> review of the first version. Go through
Uh? I just fixed the commits and squashed them together for easier handling.
I'm even using mmc_of_parse now...
> html and address the comments that were made.
> - Each of your patches should compile. Fix the order of your
> patches.
> - Submit a v3, with the changes you made. Otherwise we have no way
> of knowing what have been fixed and what didn't
Too many patches would be bloaty.
That's why I've squashed them into small and corrected patches.

> Looking forward for the next iteration!
Good :-)
You can have a look at the recent status here:;a=shortlog;h=refs/heads/20140205


Attachment: signature.asc
Description: This is a digitally signed message part.