Re: perf trace: Initial beautifier for ioctl's 'cmd' arg

From: Ben Hutchings
Date: Wed Feb 05 2014 - 04:53:32 EST

Commit 78645cf3ed32860a3e83b8e35aa469f5b844a4ba introduced a build
failure on powerpc and sparc as it redefines TCGETS. TCGETS doesn't
actually appear to be used, but in any case these and many other
architectures give it a different value than 0x5401. In fact they have
mostly different numbering of tty ioctls, in two different ranges (type
byte may be 0x54 or 0x74).

Please do this properly (actually use the macros!) or revert it.


Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part