[PATCH 3.13 012/140] usb: chipidea: need to mask INT_STATUS when write otgsc

From: Greg Kroah-Hartman
Date: Tue Feb 04 2014 - 16:47:02 EST

3.13-stable review patch. If anyone has any objections, please let me know.


From: Peter Chen <peter.chen@xxxxxxxxxxxxx>

commit 5332ff1fb63c46588656e4208201bc131627c878 upstream.

For otgsc, both enable bits and status bits are in it. So we need
to make sure the status bits are not be cleared when write enable
bits. It can fix one bug that we plug in/out Micro AB cable fast,
and sometimes, the IDIS will be cleared wrongly when handle last
ID interrupt (ID 0->1), so the current interrupt will not occur.

For stable tree: 3.12+

Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/usb/chipidea/otg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/usb/chipidea/otg.h
+++ b/drivers/usb/chipidea/otg.h
@@ -1,5 +1,5 @@
- * Copyright (C) 2013 Freescale Semiconductor, Inc.
+ * Copyright (C) 2013-2014 Freescale Semiconductor, Inc.
* Author: Peter Chen
@@ -19,12 +19,12 @@ static inline void ci_clear_otg_interrup

static inline void ci_enable_otg_interrupt(struct ci_hdrc *ci, u32 bits)
- hw_write(ci, OP_OTGSC, bits, bits);
+ hw_write(ci, OP_OTGSC, bits | OTGSC_INT_STATUS_BITS, bits);

static inline void ci_disable_otg_interrupt(struct ci_hdrc *ci, u32 bits)
- hw_write(ci, OP_OTGSC, bits, 0);
+ hw_write(ci, OP_OTGSC, bits | OTGSC_INT_STATUS_BITS, 0);

int ci_hdrc_otg_init(struct ci_hdrc *ci);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/