[PATCH 3.13 057/140] tty/serial: at91: reset rx_ring when port is shutdown

From: Greg Kroah-Hartman
Date: Tue Feb 04 2014 - 16:28:35 EST

3.13-stable review patch. If anyone has any objections, please let me know.


From: Mark Deneen <mdeneen@xxxxxxxxx>

commit bb7e73c598fb226c75f7625088a8f6a45a0fc892 upstream.

When using RX DMA, the driver won't pass any data to the uart layer
until the buffer is flipped. When the port is shutdown, the dma buffers
are unmapped, but the head and tail of the ring buffer are not reseted.
Since the serial console will keep the port open, this will only
present itself when the uart is not shared.

To reproduce the issue, with an unpatched driver, run a getty on /dev/ttyS0
with no serial console and exit. Getty will exit, and when the new one returns
you will be unable to log in. If you hold down a key long enough to fill the
DMA buffer and flip it, you can then log in.

Signed-off-by: Mark Deneen <mdeneen@xxxxxxxxx>
Acked-by: Leilei Zhao <leilei.zhao@xxxxxxxxx>
[nicolas.ferre@xxxxxxxxx: adapt to mainline kernel, handle !DMA case]
Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/tty/serial/atmel_serial.c | 6 ++++++
1 file changed, 6 insertions(+)

--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1677,6 +1677,12 @@ static void atmel_shutdown(struct uart_p

+ * Reset ring buffer pointers
+ */
+ atmel_port->rx_ring.head = 0;
+ atmel_port->rx_ring.tail = 0;
+ /*
* Free the interrupt
free_irq(port->irq, port);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/