Re: [PATCH v2 2/4] xen-blkback: fix memory leaks

From: David Vrabel
Date: Tue Feb 04 2014 - 05:33:00 EST

On 04/02/14 10:26, Roger Pau Monne wrote:
> I've at least identified two possible memory leaks in blkback, both
> related to the shutdown path of a VBD:
> - blkback doesn't wait for any pending purge work to finish before
> cleaning the list of free_pages. The purge work will call
> put_free_pages and thus we might end up with pages being added to
> the free_pages list after we have emptied it. Fix this by making
> sure there's no pending purge work before exiting
> xen_blkif_schedule, and moving the free_page cleanup code to
> xen_blkif_free.
> - blkback doesn't wait for pending requests to end before cleaning
> persistent grants and the list of free_pages. Again this can add
> pages to the free_pages list or persistent grants to the
> persistent_gnts red-black tree. Fixed by moving the persistent
> grants and free_pages cleanup code to xen_blkif_free.
> Also, add some checks in xen_blkif_free to make sure we are cleaning
> everything.

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

> + if (log_stats)
> + print_stats(blkif);

Unrelated to this series, but this log_stats stuff can be removed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at