Re: [PATCH] ip_tunnel: fix panic in ip_tunnel_xmit()

From: David Miller
Date: Mon Feb 03 2014 - 16:06:03 EST

From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Mon, 03 Feb 2014 12:52:14 -0800

> From: Eric Dumazet <edumazet@xxxxxxxxxx>
> Setting rt variable to NULL at the beginning of ip_tunnel_xmit()
> missed possible use of this variable as a scratch value.
> Also fixes a possible dst leak in tunnel_dst_check() :
> If we had to call tunnel_dst_reset(), we forgot to
> release the reference on dst.
> Merges tunnel_dst_get()/tunnel_dst_check() into
> a single tunnel_rtable_get() function for clarity.
> Many thanks to Tommi for his report and tests.
> Fixes: 7d442fab0a67 ("ipv4: Cache dst in tunnels)"
> Reported-by: Tommi Rantala <tt.rantala@xxxxxxxxx>
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Tested-by: Tommi Rantala <tt.rantala@xxxxxxxxx>
> Cc: Tom Herbert <therbert@xxxxxxxxxx>
> Cc: Maciej Żenczykowski <maze@xxxxxxxxxx>

Applied, thanks Eric.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at