diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 87529181efcc..475837400897 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -379,7 +379,7 @@ static void ioat1_dma_free_chan_resources(struct dma_chan *c) if (ioat->desccount == 0) return; - tasklet_disable(&chan->cleanup_task); + tasklet_kill(&chan->cleanup_task); del_timer_sync(&chan->timer); ioat1_cleanup(ioat); @@ -790,7 +790,7 @@ int ioat_dma_self_test(struct ioatdma_device *device) dma_addr_t dma_dest, dma_src; dma_cookie_t cookie; int err = 0; - struct completion cmp; + DECLARE_COMPLETION_ONSTACK(cmp); unsigned long tmo; unsigned long flags; @@ -836,7 +836,6 @@ int ioat_dma_self_test(struct ioatdma_device *device) } async_tx_ack(tx); - init_completion(&cmp); tx->callback = ioat_dma_test_callback; tx->callback_param = &cmp; cookie = tx->tx_submit(tx); diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c index 5d3affe7e976..f9d7a44883e2 100644 --- a/drivers/dma/ioat/dma_v2.c +++ b/drivers/dma/ioat/dma_v2.c @@ -809,7 +809,7 @@ void ioat2_free_chan_resources(struct dma_chan *c) if (!ioat->ring) return; - tasklet_disable(&chan->cleanup_task); + tasklet_kill(&chan->cleanup_task); del_timer_sync(&chan->timer); device->cleanup_fn((unsigned long) c); device->reset_hw(chan);