Re: [PATCH] firmware/google: drop 'select EFI' to avoid recursive dependency
From: Ard Biesheuvel
Date: Thu Jan 23 2014 - 16:48:51 EST
On 23 January 2014 22:40, Mike Waychison <mikew@xxxxxxxxxx> wrote:
> On Thu, Jan 23, 2014 at 1:36 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
>> On Thu, 23 Jan 2014, Ard Biesheuvel wrote:
>>> The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI. This
>>> causes problems on other archs when introducing DMI support that
>>> depends on EFI, as it results in a recursive dependency:
>>> arch/arm/Kconfig:1845:error: recursive dependency detected!
>>> arch/arm/Kconfig:1845: symbol DMI depends on EFI
>>> Fix by changing the 'select EFI' to a 'depends on EFI'.
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
Indeed, get_maintainer.pl did not produce a name, or I would have
cc'ed you directly.
>>> drivers/firmware/google/Kconfig | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
>>> index 2f21b0bfe653..29c8cdda82a1 100644
>>> --- a/drivers/firmware/google/Kconfig
>>> +++ b/drivers/firmware/google/Kconfig
>>> @@ -12,8 +12,7 @@ menu "Google Firmware Drivers"
>>> config GOOGLE_SMI
>>> tristate "SMI interface for Google platforms"
>>> - depends on ACPI && DMI
>>> - select EFI
>>> + depends on ACPI && DMI && EFI
>>> select EFI_VARS
>>> Say Y here if you want to enable SMI callbacks for Google
>> Adding Mike Waychison <mikew@xxxxxxxxxx> to the cc since this is his code,
>> but it looks good to me.
>> $ ./scripts/get_maintainer.pl -f drivers/firmware/google/Kconfig
>> linux-kernel@xxxxxxxxxxxxxxx (open list)
>> I wonder why he's not listed as a recipient for patches from
>> get_maintainer.pl since it's clearly obvious he wrote the entire file.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/