[PATCH 3/4] mtd: block2mtd: check device size

From: Fabian Frederick
Date: Thu Jan 23 2014 - 14:53:38 EST


fixme applied : check device size is a multiple of erasesize.

Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
---
drivers/mtd/devices/block2mtd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 8071596..f0fd4fc 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -209,7 +209,6 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
}


-/* FIXME: ensure that mtd->size % erase_size == 0 */
static struct block2mtd_dev *add_device(char *devname, int erase_size)
{
const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
@@ -250,6 +249,11 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
goto devinit_err1;
}

+ if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
+ pr_err("erasesize muse be a divisor of device size\n");
+ goto devinit_err1;
+ }
+
mutex_init(&dev->write_mutex);

/* Setup the MTD structure */
--
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/