Re: [PATCH 1/8] ASoC: fsl: Add VF610 soc audio card Kconfig

From: Mark Brown
Date: Thu Jan 23 2014 - 13:38:51 EST

On Thu, Jan 23, 2014 at 01:02:43PM +0800, Xiubo Li wrote:

> +menuconfig SND_VF610_SOC
> + tristate "SoC Audio for Freescale VF610 CPUs"
> + select DMA_ENGINE
> + help
> + Say Y or M if you want to add support for codecs attached to
> + the VF610 CPUs.
> +
> + This will enable Freeacale SAI and SGTL5000 codec, and an extra
> + TWR-AUDIO-SGTL sub-board is needed for SGTL5000.

This bit is OK but...

> +config SND_SOC_VF610_SGTL5000
> + tristate "SoC Audio support for VF610 boards with SGTL5000"
> + depends on OF && I2C
> + select SND_SOC_FSL_SAI
> + select SND_SOC_SGTL5000
> + select SND_SIMPLE_CARD

...for simple card since the whole idea is to support any CODEC with the
same driver we should probably just make sure that all the individual
drivers can be enabled in Kconfig, that way we don't have to have
specific Kconfig entries for boards and loose some of the benefit of the
generic card. I sent a patch earlier exposing the OF supporting CODEC
drivers, one for at least some of the Freescale CPU drivers was sent to
the list recently too but there were some review comments.

Attachment: signature.asc
Description: Digital signature