Re: [PATCH v10 1/4] qrwlock: A queue read/write lock implementation

From: Linus Torvalds
Date: Thu Jan 23 2014 - 12:52:33 EST


On Thu, Jan 23, 2014 at 9:47 AM, Waiman Long <waiman.long@xxxxxx> wrote:
>
> Thank for the info. I am less familiar with that kind of issues on other
> architecture. I will add a smp_mb__after_atomic_dec() & send out a new
> patch.

SInce it's the unlock path,. you need to use the "mb__*before*"
versions, since presumably you want to protect what is inside the lock
from leaking out, not some random thing after the lock from leaking
in..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/