Re: [PATCH] numa, mem-hotplug: Fix stack overflow in numa whenseting kernel nodes to unhotpluggable.

From: Dave Jones
Date: Thu Jan 23 2014 - 09:41:46 EST


On Wed, Jan 22, 2014 at 10:15:51PM -0800, David Rientjes wrote:
> On Thu, 23 Jan 2014, Dave Jones wrote:
>
> > It's 10, because I had MAXSMP set.
> >
> > So, MAX_NUMNODES = 1 << 10
> >
> > And the bitmask is made of longs. 1024 of them.
> >
> > How does this work ?
> >
>
> It's 1024 bits.

ok, I got lost in the maze of macros.

128 bytes is a pretty small amount of stack though, so I'm just as confused
as to what the actual bug here is.


After trying the proposed fix, I got another oops in the early init code..

<trace>
nr_free_zone_pages
nr_free_pagecache_pages
build_all_zonelists
start_kernel
<rip> ffffffffbc164b1e next_zones_zonelist
<rsp> ffffffffbcc01f00

I'll poke at it more in the morning. Too sleepy.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/