Re: [PATCH v2 4/4] ARM:STi: STiH415: Add interrupt support for pin controller

From: Linus Walleij
Date: Thu Jan 23 2014 - 02:33:54 EST


On Thu, Jan 16, 2014 at 4:37 PM, <srinivas.kandagatla@xxxxxx> wrote:

> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx>
>
> This patch adds interrupt support for STiH415 pin controllers.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Merge this through ARM SoC.

> + reg = <0xfe61f080 0x4>;
> + reg-names = "irqmux";

Aha so that is how it looks when you handle the separate
mux reg, well I can't think of anything better and this works
fine for me.

The alternative would be to have a syscon thing using regmap
such as drivers/mfd/syscon.c but I really cannot decide
between these two design patterns for odd registers.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/