Re: [PATCH v2 2/2] regulator: s5m8767: Document new bindings forBuck9 GPIO control

From: Mark Brown
Date: Wed Jan 22 2014 - 14:49:58 EST

On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote:
> Add documentation for new bindings for controlling (enable/disable) the
> Buck9 Converter by GPIO (BUCK9EN).

Your CC list for this is *very* large...

> + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled
> + by GPIO (valid only for buck9).
> + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO
> + controlling this regulator (valid only for buck9).
> + This property is required when 's5m8767,pmic-ext-control-enable' is specified.

In what situation might the GPIO be present but not usable - can't we
just use the presence of the GPIO property? Also GPIO properties are
supposed to be always "-gpios".

Attachment: signature.asc
Description: Digital signature