Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot+ sbc_parse_cdb

From: Sagi Grimberg
Date: Wed Jan 22 2014 - 13:01:04 EST


On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote:
+ cmd->prot_handover = PROT_SEPERATED;
I know that we are not planning to support interleaved mode at the
moment, But I think
that the protection handover type is the backstore preference and should
be taken from se_dev.
But it is not that important for now...

Yeah, I figured since the RDMA pieces needed the handover type defined
in some form, it made sense to include PROT_SEPERATED hardcoded here,
but stopped short of adding se_dev->prot_handler for the first round
merge.

--nab


Actually they don't, I just added them in iSER code to demonstrate the HW ability.
If we are not planning to support that (although as MKP mentioned it might be useful in some cases),
you can remove that for now and we can add it in the future - iSER can ignore it for now (I'll refactor the patches).

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/