RE: [PATCH] cpufreq: Align all CPUs to the same frequency if usingshared clock
From: Li, Zhuangzhi
Date: Wed Jan 22 2014 - 01:26:30 EST
> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@xxxxxxxxxx]
> Sent: Wednesday, January 22, 2014 1:18 PM
> To: Li, Zhuangzhi
> Cc: Rafael J. Wysocki; cpufreq@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx;
> Linux Kernel Mailing List; Liu, Chuansheng
> Subject: Re: [PATCH] cpufreq: Align all CPUs to the same frequency if using
> shared clock
> On 21 January 2014 13:42, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > On 21 January 2014 12:56, Li, Zhuangzhi <zhuangzhi.li@xxxxxxxxx> wrote:
> >> Thanks for reviewing.
> > Its my job :)
> >> Sorry for make you misunderstanding, on our x86 platform, we want all the
> CPUs share one policy by setting CPUFREQ_SHARED_TYPE_ALL, not share one
> HW clock line.
> > I see.. Then probably your patch makes sense. But it is obviously not
> > required for every platform that exists today.
> > Please update it to do it only for drivers that have set
> > CPUFREQ_SHARED_TYPE_ALL..
> One more thing, who has set different frequencies to these cores?
> I hope kernel hasn't ?
> In that case, probably you are fixing a bootloader bug in kernel?
> What about doing this in bootloader then?
I don't think it's a real bug in bootloader, the bootloader can set CPUs to different frequencies according to actually requirements(Power saving first or Performance first),
the CPUs freq policy are initialized in kernel, if the kernel want to share one CPU policy(using CPUFREQ_SHARED_TYPE_ALL type), it should ensure all CPUs frequencies aligned first,
don't depend on the bootloader CPUs Pre-states, then the kernel can have better compatibility.
If the kernel uses CPUFREQ_SHARED_TYPE_ALL policy, the patch can ensure these:
1. If all CPUs are in the same P-state, it does nothing when cpufreq registering
2. If the CPUs are in different P-states, all the other CPUs are aligned once to current frequency of CPU0 according to the present policy.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/