Re: [GIT PULL] GPIO bulk changes for v3.14

[Stephen Rothwell]

Hi all,

On Tue, 21 Jan 2014 10:11:39 -0800 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 21, 2014 at 12:36 AM, Linus Walleij
> <linus.walleij@xxxxxxxxxx> wrote:
> >
> > here is the big GPIO pull request for the v3.14 series.
> 
> Ugh. It does not compile for me. The problem seems to be that the
> gpio-mcp23s08.c driver only compiles in OF environments, but isn't
> properly restricted to them:
> 
>   drivers/gpio/gpio-mcp23s08.c: In function âmcp23s08_irq_setupâ:
>   drivers/gpio/gpio-mcp23s08.c:482:46: error: âstruct gpio_chipâ has
> no member named âof_nodeâ
>     mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio,
> 
> and similar other errors.

Yep, reported when it entered linux-next.

> Introduced by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq
> functionality for i2c chips") as far as I can tell.
>
> >  It's big this time but has been brewing in linux-next for
> > some time and it's all good stuff IMO
> 
> The fact that it doesn't even compile makes me doubt your statement
> that it has been in linux-next. It doesn't even pass a basic
> allmodconfig build.

That particular commit was reverted in linux-next when it first turned up
on Monday and again yesterday.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature