Re: [PATCH 4/5 v3] input: tc3589x-keypad: support probing from device tree

From: Linus Walleij
Date: Tue Jan 21 2014 - 08:32:57 EST

On Tue, Jan 21, 2014 at 2:28 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Nov 26, 2013 at 3:34 AM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> On Tue, Nov 12, 2013 at 04:31:01PM +0100, Linus Walleij wrote:
>>> irq = platform_get_irq(pdev, 0);
>>> --
>> Don't you also want to add MODULE_DEVICE_TABLE entry?
> Probably, but that'd be a separate subject though, I think?
> I'll make a patch for this so you get something you can
> actually merge.

No, wait, this driver only matches on driver name, it has no
match table of any kind. This is typical for MFD-spun cells
if they don't need additional info from the compat match.
I think it only needs the MODULE_ALIAS() it already

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at