Re: [PATCH] [V2] MAINTAINERS: Add dts files for r8 series to SHMOBILE

From: Simon Horman
Date: Mon Jan 20 2014 - 19:56:50 EST


Hi Ben,

thanks for your work on this.

On Mon, Jan 20, 2014 at 04:10:32PM +0000, Ben Dooks wrote:
> Add a number of files to the list of files covered by SHMOBILE
> so any changes to these can be reported with get_maintailers.pl
> for the current SHMOILE architectures.

I'm fine with you only addressing r8 and r7 SoCs, I am happy
to make an incremental patch to cover the stragglers (sh7*, emev2).
And I would be even happier if this patch didn't suffer excessive
bike-shedding. But I think there are some minor inconsistencies in this
patch.

Firstly, I think the subject should probably mention r7 and defconfigs.

>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> v2:
> - add defconfigs and r7 configurations
> - fix path to dt-bindings
>
> Cc: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Magnus Damm <magnus.damm@xxxxxxxxx>
> Cc: Simon Horman <horms@xxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-sh@xxxxxxxxxxxxxxx
> ---
> MAINTAINERS | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6c20792..f74d830 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1239,7 +1239,14 @@ Q: http://patchwork.kernel.org/project/linux-sh/list/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next
> S: Supported
> F: arch/arm/mach-shmobile/
> +F: arch/arm/boot/dts/r8*
> +F: arch/arm/boot/dts/r7*
> +F: arch/arm/configs/bockw_defconfig
> +F: arch/arm/configs/genmai_defconfig
> +F: arch/arm/configs/lager_defconfig
> +F: arch/arm/configs/marzen_defconfig

I believe you should ad the following as they are for boards
that use SoCs whose name matches r8*.

arch/arm/configs/armadillo800eva_defconfig
arch/arm/configs/ape6evm_defconfig
arch/arm/configs/koelsch_defconfig

> F: drivers/sh/
> +F: include/dt-bindings/clock/r8a*
>
> ARM/SOCFPGA ARCHITECTURE
> M: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/