Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call todevice probe
From: Mark Brown
Date: Mon Jan 20 2014 - 18:15:25 EST
On Mon, Jan 20, 2014 at 09:43:05PM +0000, Alan Cox wrote:
> The dynamic major/minor is the right patch. If the userspace breaks then
> the userspace was broken, but I see no evidence in the discussion that
> the userspace broke.
The userspace breakage is that if someone has a static /dev that doesn't
handle any dynamic devices then renumbering the device will cause that
static /dev to stop matching the kernel.
> Thats what the list says. Samsung should have followed the rules, they
> didn't so they get to pick up the pieces. The Amba driver wants moving as
> well. It's easy. If you want something to be ABI then make sure you get
> it upstream first, if not you get to own all the pain down the line.
This stuff is all upstream already, a quick check suggests both drivers
predate git - it's been noticed because the ARM multiplatform work has
caused people to try booting kernels with both built in.
> If the hardware isn't present then the driver shouldn't even register
> with the tty layer in the first place so it doesn't make any resource
> differeneces either for properly written code.
Right, that's not the idiom that has been followed by any of serial
drivers though so needs fixing too.
Description: Digital signature