Re: [RFC PATCHv2 2/2] Change khugepaged to respect MMF_THP_DISABLEflag

From: Alex Thorlton
Date: Mon Jan 20 2014 - 14:58:00 EST


On Sun, Jan 19, 2014 at 01:49:57AM +0200, Kirill A. Shutemov wrote:
> __khugepaged_enter() has VM_BUG_ON(khugepaged_test_exit(mm)).
> Do we really want to crash there if MMF_THP_DISABLE is set?

No, definitely not. Upon review, khugepaged_test_exit is the wrong
place to do this check. I think I need to move it up to
khugepaged_scan_mm_slot for this to work correctly. Thanks for pointing
that out, Kirill.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/