Re: [RFC PATCH 1/3] zram: delete zram_init_device() function

From: Minchan Kim
Date: Sun Jan 19 2014 - 23:42:36 EST

Hello Sergey,

Looks good to me and I found a bug which had been in there so I rebased
this patch on the top.

On Fri, Jan 17, 2014 at 02:04:15PM +0300, Sergey Senozhatsky wrote:
> allocate new `zram_meta' in disksize_store() only for uninitialised
> zram device, saving a number of allocations and deallocations in case
> if disksize_store() was called on currently used device. at the same
> time zram_meta stack variable is not necessary, because we can set
> ->meta directly. there is also no need in setting QUEUE_FLAG_NONROT
> queue on every disksize_store(), set it once during device creation.
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>


Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Kind regards,
Minchan Kim
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at