Re: ping [PATCH v3] WAN: Adding support for Lantiq PEF2256 E1 chipset(FALC56)

From: Rob Landley
Date: Sun Jan 19 2014 - 19:51:06 EST

On 01/19/14 13:34, Joe Perches wrote:
On Sun, 2014-01-19 at 19:07 +0100, Christophe Leroy wrote:
Pinging this watch as we got no feedback since 22 Nov, although we have taken
into account reviews from v1 and v2.

The patch adds WAN support for Lantiq FALC56 - PEF2256 E1 Chipset.
+static ssize_t fs_attr_Tx_TS_store(struct device *dev,
+ struct device_attribute *attr, const char *buf,
+ size_t count)
+ struct net_device *ndev = dev_get_drvdata(dev);
+ struct pef2256_dev_priv *priv = dev_to_hdlc(ndev)->priv;
+ unsigned long value;
+ int ret = kstrtoul(buf, 16, (long int *)&value);

unportable cast

How is that not portable? It's long == pointer on Linux, which supports LP64 on all targets. (As do BSD, MacOSX, android, and iOS.)

Do you mean it's not portable to Windows?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at