Re: [PATCH v6] Bluetooth: Add hci_h4p driver

From: Pavel Machek
Date: Fri Jan 17 2014 - 07:15:00 EST


> > Add hci_h4p bluetooth driver to bluetooth-next. This device is used
> > for example on Nokia N900 cell phone.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> > Signed-off-by: Pavel Machek <pavel@xxxxxx>
> > Thanks-to: Sebastian Reichel <sre@xxxxxxxxxx>
> > Thanks-to: Joe Perches <joe@xxxxxxxxxxx>
> >
> > ---
> >
> > Changes from v5: Comment fixes and some refactoring suggested by
> > Joe Perches. Please apply.

> > --- /dev/null
> > +++ b/drivers/bluetooth/hci_h4p.h
> can we please get the naming straight. File names do not start with hci_ anymore. We moved away from it since that term is too generic.

Ok, this is easy.

> > + struct timer_list lazy_release;
> Timer? Not delayed work?

But these changes sound like bigger piece of refactoring, and more is
suggested below. Which is good, but will be tricky to develop/test on
bluetooth-next, as running Maemo is really needed for testing.

So... this will take longer than expected, and I believe it makes
sense to push it to staging, first. That will bring linux-n900 tree
closer to mainline, and preserve more of history.

(cesky, pictures)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at