Re: [PATCH 2/2] Input: edt-ft5x06: Add DT support
From: Simon Budig
Date: Thu Jan 16 2014 - 20:50:24 EST
On 16/01/14 08:49, Lothar WaÃmann wrote:
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
>>> @@ -0,0 +1,31 @@
>>> +* EDT FT5x06 Multiple Touch Controller
>>> +- threshold: allows setting the "click"-threshold in the range from 20 to 80.
>>> +- gain: sensitivity (0..31) (lower value -> higher sensitivity)
>>> +- offset: edge compensation (0..31)
>>> +- report_rate: report rate (3..14)
>> s/_/-/ on property names please. Also, it may make sense to prefix these
>> as they're rather generic sounding names.
>> Could you elaborate on these a litle please? What units are each of
>> these in? Why does it make sense to have them in the dt?
> I just converted them from being passed via platform_data. I have no
> idea what they actually control and what units they use. I could not
> even find a manual where they are documented.
> Maybe Simon Budig can help out here as the original driver author.
The units are not specified in the datasheets available to me. I suspect
that these are some sort of counter values related to the cap sensing.
The defaults differ for the different size glasses, so I really suspect
these are basically just numbers.
The only somewhat reasonable unit is available for the report-rate: it
is specified as about <value> * 10 touch reports per second.
Simon Budig kernel concepts GmbH
simon.budig@xxxxxxxxxxxxxxxxx Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
Description: OpenPGP digital signature