Re: [PATCH v2 2/2] net/mlx4_core: clean up srq_res_start_move_to()

From: David Miller
Date: Thu Jan 16 2014 - 19:05:29 EST

From: Paul Bolle <pebolle@xxxxxxxxxx>
Date: Tue, 14 Jan 2014 20:46:52 +0100

> Building resource_tracker.o triggers a GCC warning:
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_SRQ_wrapper':
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3202:17: warning: 'srq' may be used uninitialized in this function [-Wmaybe-uninitialized]
> atomic_dec(&srq->mtt->ref_count);
> ^
> This is a false positive. But a cleanup of srq_res_start_move_to() can
> help GCC here. The code currently uses a switch statement where a plain
> if/else would do, since only two of the switch's four cases can ever
> occur. Dropping that switch makes the warning go away.
> While we're at it, add some missing braces, and convert state to the
> correct type.
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at