[tip:sched/core] sched: Fix up attr::sched_priority warning

From: tip-bot for Peter Zijlstra
Date: Thu Jan 16 2014 - 08:41:22 EST

Commit-ID: 0bb040a44381261c0729636abbe03caeedb7d72e
Gitweb: http://git.kernel.org/tip/0bb040a44381261c0729636abbe03caeedb7d72e
Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
AuthorDate: Wed, 15 Jan 2014 17:15:13 +0100
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Thu, 16 Jan 2014 09:27:16 +0100

sched: Fix up attr::sched_priority warning

Fengguang Wu reported the following build warning:

> kernel/sched/core.c:3067 __sched_setscheduler() warn: unsigned 'attr->sched_priority' is never less than zero.

Since it doesn't make sense for attr::sched_priority to be negative,
remove the check, since we already test for an upper limit any actual
negative values passed in through the old param::sched_priority field
will still be detected.

Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Juri Lelli <juri.lelli@xxxxxxxxx>
Cc: Dario Faggioli <raistlin@xxxxxxxx>
Fixes: d50dde5a10f3 ("sched: Add new scheduler syscalls to support an extended scheduling parameters ABI")
Link: http://lkml.kernel.org/n/tip-fid9nalzii2r5voxtf4eh5kz@xxxxxxxxxxxxxx
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
kernel/sched/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index e9212eb..5a6ccdf 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3282,8 +3282,7 @@ recheck:
* 1..MAX_USER_RT_PRIO-1, valid priority for SCHED_NORMAL,
- if (attr->sched_priority < 0 ||
- (p->mm && attr->sched_priority > MAX_USER_RT_PRIO-1) ||
+ if ((p->mm && attr->sched_priority > MAX_USER_RT_PRIO-1) ||
(!p->mm && attr->sched_priority > MAX_RT_PRIO-1))
return -EINVAL;
if ((dl_policy(policy) && !__checkparam_dl(attr)) ||
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/