Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump anarbitrary pagetable

From: Dave Young
Date: Thu Jan 16 2014 - 01:46:36 EST

On 01/15/14 at 08:04pm, H. Peter Anvin wrote:
> On 01/15/2014 07:03 PM, Dave Young wrote:
> >>
> >> making something harder to grep and less standardized is hardly cleaner
> >> and these things compile to nothing for non-modules.
> >
> > It's not nothing, just very small increasement:
> > text data bss dec hex filename
> > 7636121 1391824 9355264 18383209 1188169 vmlinux
> >
> > text data bss dec hex filename
> > 7636113 1391824 9355264 18383201 1188161 vmlinux
> >
> > I do not want to insist on this minor problem, if you want please keep it.
> >
> Now *that* we can fix by making these macros expand to nothing if you
> are compiling for a nonmodule, right? That will benefit code that
> legitimately can compile as a module but is configured "y", too.

I'm not sure expanding to nothing is a good fix.

For built-in module we still can retrieve the module info in userspace via
/usr/sbin/modinfo, if we expand the Macros to nothing then userspace will
not see thus infomation anymore.

Another advantage of built-in module is it has module specific parameters which
should not necessary a generic kernel parameter.

If the *module* is really a nonmodule, IMHO it should add the information to
or add other macros macros instead of reuse the MODULE_*.

BTW, for macros in this file, for a nonmodule "license GPL" is unnecessary at all.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at