Re: [PATCH net-next RFC] virtio-net: drop rq->max and rq->num

[Jason Wang]

On 01/16/2014 08:46 AM, David Miller wrote:
> From: Rusty Russell<rusty@xxxxxxxxxxxxxxx>
> Date: Thu, 16 Jan 2014 10:25:26 +1030
>
> > Rusty Russell<rusty@xxxxxxxxxxxxxxx>  writes:
> > > Jason Wang<jasowang@xxxxxxxxxx>  writes:
> > > > It looks like there's no need for those two fields:
> > > >
> > > > - Unless there's a failure for the first refill try, rq->max should be always
> > > >    equal to the vring size.
> > > > - rq->num is only used to determine the condition that we need to do the refill,
> > > >    we could check vq->num_free instead.
> > > > - rq->num was required to be increased or decreased explicitly after each
> > > >    get/put which results a bad API.
> > > >
> > > > So this patch removes them both to make the code simpler.
> > > Nice.  These fields date from when the vq struct was opaque.
> > >
> > > Applied,
> > > Rusty.
> > Oops, this doesn't require any core virtio changes, so it's for DaveM:
> >
> > Acked-by: Rusty Russell<rusty@xxxxxxxxxxxxxxx>
> Jason please repost this with Rusty's ACK, thanks.

Sure, will repost.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/