Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump anarbitrary pagetable

[Dave Young]

On 01/15/14 at 06:41pm, Arjan van de Ven wrote:
> On 1/15/2014 5:44 PM, Dave Young wrote:
> >On 01/15/14 at 06:11am, H. Peter Anvin wrote:
> >>On 01/14/2014 05:16 PM, Dave Young wrote:
> >>>>
> >>>>Why the [Finnish] do you feel that information needs to be in a
> >>>>different form because it is (currently!) not available as a module?
> >>>
> >>>I think moving them to comment can avoid including extra linux/module.h
> >>>
> >>
> >>And that matters, why?
> >
> >At least the code will be cleaner and kernel size will be a bit smaller?
> >
> 
> making something harder to grep and less standardized is hardly cleaner
> and these things compile to nothing for non-modules.

It's not nothing, just very small increasement:
   text	   data	    bss	    dec	    hex	filename
7636121	1391824	9355264	18383209	1188169	vmlinux

   text	   data	    bss	    dec	    hex	filename
7636113	1391824	9355264	18383201	1188161	vmlinux

I do not want to insist on this minor problem, if you want please keep it.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/