Re: [PATCH v2 tip/core/timers] Crude timer-wheel latency hacks

From: Paul E. McKenney
Date: Wed Jan 15 2014 - 21:37:02 EST


On Wed, Jan 15, 2014 at 11:22:41PM +0100, Thomas Gleixner wrote:
> Paul,
>
> On Tue, 14 Jan 2014, Paul E. McKenney wrote:
> > The following three patches provide some crude timer-wheel latency
> > patches. I understand that a more comprehensive solution is in progress,
> > but in the meantime, these patches work well in cases where a given
> > CPU has either zero or one timers pending, which is a common case for
> > NO_HZ_FULL kernels. So, on the off-chance that this is helpful to
> > someone, the individual patches are as follows:
>
> so far that makes sense, though I'd rather like to redesign the whole
> timer wheel mess than adding more duct tape to it.

This is supposed to be in addition you your redesign, absolutely not
instead of your redesign. For one thing, hopefully your redesign
will avoid jiffy-scanning in the case where the CPU has a pair of
timers separated by many jiffies. My patches won't help in that case.

My patches are instead intended for testing in the meantime, and they
do help a bit in some common NO_HZ_FULL situations.

> I can't dig into
> the details right now as I'm dead tired and about to leave for a
> funeral. i'll have a detailed look at this at the weekend.

My sympathies!

And I will be sending out an updated series shortly anyway.

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/