Re: [PATCH tip/core/timers 3/4] timers: Reduce future__run_timers() latency for newly emptied list

From: Paul E. McKenney
Date: Wed Jan 15 2014 - 21:23:46 EST


On Wed, Jan 15, 2014 at 06:08:35PM +0100, Oleg Nesterov wrote:
> On 01/14, Paul E. McKenney wrote:
> >
> > @@ -700,6 +700,7 @@ static int detach_if_pending(struct timer_list *timer, struct tvec_base *base,
> > base->next_timer = base->timer_jiffies;
> > }
> > base->all_timers--;
> > + (void)catchup_timer_jiffies(base);
>
> Agreed, but I think that detach_expired_timer() should do the same,
> this can stop main loop in __run_timers().

Good point, added to detach_expired_timer().

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/